[ChannelGenerator] Verify the physical feasibility of DMA channel allocation #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Zhewen
requested review from
makslevental,
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
Yu-Zhewen
force-pushed
the
zhewen_channel_generator_check
branch
from
65c0b81 to
59a0b32
Compare
yzhang93
approved these changes
Jan 3, 2025
Comment on lines
25
to
28
| if (!device) | ||
| return workgroupOp->emitOpError() | ||
| << "could not find an AMDAIEDevice attribute"; | ||
| AMDAIEDeviceModel deviceModel = AMDAIE::getDeviceModel(device.value()); |
There was a problem hiding this comment.
Nit: It looks better if you use { } around the body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.